feat(ripples): support updating global ripple options at runtime #14705
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
added
target: minor
This comment has been minimized.
This comment has been minimized.
googlebot
added
the
cla: yes
devversion
force-pushed
the
feat/disable-ripples-runtime
branch
from
bdc9238 to
e32f201
Compare
crisbeto
reviewed
Jan 3, 2019
|
@crisbeto Since this is already possible right now, but just breaks for our custom Also since it has been requested and I personally think it's valuable and didn't even require some changes to |
jelbourn
reviewed
Jan 9, 2019
* Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime. Closes angular#9729
devversion
force-pushed
the
feat/disable-ripples-runtime
branch
from
e32f201 to
665c3ea
Compare
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…ular#14705) * feat(ripples): support updating global ripple options at runtime * Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime. Closes angular#9729 * fixup! feat(ripples): support updating global ripple options at runtime Address feedback
s2-abdo
pushed a commit
to s2-abdo/material2
that referenced
this pull request
Jan 18, 2019
…ular#14705) * feat(ripples): support updating global ripple options at runtime * Allows updating any global ripple option at runtime. This makes it possible for developers to disable ripples at runtime. Closes angular#9729 * fixup! feat(ripples): support updating global ripple options at runtime Address feedback
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9729